Skip to content

add inner transaction info (if present) to outer transaction tx return#6445

Draft
mvadari wants to merge 3 commits intoXRPLF:developfrom
mvadari:batch-rpc
Draft

add inner transaction info (if present) to outer transaction tx return#6445
mvadari wants to merge 3 commits intoXRPLF:developfrom
mvadari:batch-rpc

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Feb 26, 2026

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mvadari mvadari added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Feb 26, 2026
@codecov
Copy link

codecov bot commented Feb 27, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.8%. Comparing base (1a7f824) to head (79d8abc).

Files with missing lines Patch % Lines
src/xrpld/rpc/handlers/Tx.cpp 97.6% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6445   +/-   ##
=======================================
  Coverage     79.8%   79.8%           
=======================================
  Files          858     858           
  Lines        67757   67798   +41     
  Branches      7557    7555    -2     
=======================================
+ Hits         54065   54108   +43     
+ Misses       13692   13690    -2
Files with missing lines Coverage Δ
src/xrpld/rpc/handlers/Tx.cpp 93.6% <97.6%> (+1.2%) ⬆️

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mvadari